[libcxx-commits] [libcxx] r362465 - We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863

[Shoaib Meenai via libcxx-commits]

We haven't actually bumped up our minimum requirement to 5.1 yet; our minimum is still 4.8. See http://lists.llvm.org/pipermail/llvm-dev/2019-May/132204.html

From: libcxx-commits <libcxx-commits-bounces at lists.llvm.org> on behalf of Marshall Clow via libcxx-commits <libcxx-commits at lists.llvm.org>
Reply-To: Marshall Clow <mclow.lists at gmail.com>
Date: Monday, June 3, 2019 at 7:04 PM
To: "libcxx-commits at lists.llvm.org" <libcxx-commits at lists.llvm.org>
Subject: [libcxx-commits] [libcxx] r362465 - We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863

Author: marshall
Date: Mon Jun  3 19:07:11 2019
New Revision: 362465

URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D362465-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=aIdLgHjb0F9UMGeahZnbcmhFLqKDYasJ0IpXulpkUO4&e=
Log:
We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863

Modified:
    libcxx/trunk/include/string_view

Modified: libcxx/trunk/include/string_view
URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxx_trunk_include_string-5Fview-3Frev-3D362465-26r1-3D362464-26r2-3D362465-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=qVGmX3rTx5b485s_k5D_nBGfpIFEf2gthbrnYbsDrKQ&e=
==============================================================================
--- libcxx/trunk/include/string_view (original)
+++ libcxx/trunk/include/string_view Mon Jun  3 19:07:11 2019
@@ -228,9 +228,9 @@ public:
     basic_string_view(const _CharT* __s, size_type __len) _NOEXCEPT
         : __data(__s), __size(__len)
     {
-// #if _LIBCPP_STD_VER > 11
-//         _LIBCPP_ASSERT(__len == 0 || __s != nullptr, "string_view::string_view(_CharT *, size_t): received nullptr");
-// #endif
+#if _LIBCPP_STD_VER > 11
+    _LIBCPP_ASSERT(__len == 0 || __s != nullptr, "string_view::string_view(_CharT *, size_t): received nullptr");
+#endif
     }
     _LIBCPP_CONSTEXPR _LIBCPP_INLINE_VISIBILITY


_______________________________________________
libcxx-commits mailing list
libcxx-commits at lists.llvm.org<mailto:libcxx-commits at lists.llvm.org>
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_libcxx-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=DNKrc5Upj5hrDIRx3inhpFd5HiToHdEW8ZG_Emb20ZU&e=

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190604/78409644/attachment-0001.html>