<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">We haven't actually bumped up our minimum requirement to 5.1 yet; our minimum is still 4.8. See http://lists.llvm.org/pipermail/llvm-dev/2019-May/132204.html<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:.5in"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">libcxx-commits <libcxx-commits-bounces@lists.llvm.org> on behalf of Marshall Clow via libcxx-commits <libcxx-commits@lists.llvm.org><br>
<b>Reply-To: </b>Marshall Clow <mclow.lists@gmail.com><br>
<b>Date: </b>Monday, June 3, 2019 at 7:04 PM<br>
<b>To: </b>"libcxx-commits@lists.llvm.org" <libcxx-commits@lists.llvm.org><br>
<b>Subject: </b>[libcxx-commits] [libcxx] r362465 - We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Author: marshall<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Date: Mon Jun 3 19:07:11 2019<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">New Revision: 362465<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D362465-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=aIdLgHjb0F9UMGeahZnbcmhFLqKDYasJ0IpXulpkUO4&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D362465-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=aIdLgHjb0F9UMGeahZnbcmhFLqKDYasJ0IpXulpkUO4&e=</a>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Log:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Modified:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> libcxx/trunk/include/string_view<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Modified: libcxx/trunk/include/string_view<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxx_trunk_include_string-5Fview-3Frev-3D362465-26r1-3D362464-26r2-3D362465-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=qVGmX3rTx5b485s_k5D_nBGfpIFEf2gthbrnYbsDrKQ&e=">
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxx_trunk_include_string-5Fview-3Frev-3D362465-26r1-3D362464-26r2-3D362465-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=qVGmX3rTx5b485s_k5D_nBGfpIFEf2gthbrnYbsDrKQ&e=</a>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">==============================================================================<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">--- libcxx/trunk/include/string_view (original)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+++ libcxx/trunk/include/string_view Mon Jun 3 19:07:11 2019<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">@@ -228,9 +228,9 @@ public:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> basic_string_view(const _CharT* __s, size_type __len) _NOEXCEPT<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> : __data(__s), __size(__len)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> {<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-// #if _LIBCPP_STD_VER > 11<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-// _LIBCPP_ASSERT(__len == 0 || __s != nullptr, "string_view::string_view(_CharT *, size_t): received nullptr");<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">-// #endif<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+#if _LIBCPP_STD_VER > 11<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+ _LIBCPP_ASSERT(__len == 0 || __s != nullptr, "string_view::string_view(_CharT *, size_t): received nullptr");<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">+#endif<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> }<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"> _LIBCPP_CONSTEXPR _LIBCPP_INLINE_VISIBILITY<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">_______________________________________________<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">libcxx-commits mailing list<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="mailto:libcxx-commits@lists.llvm.org">libcxx-commits@lists.llvm.org</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_libcxx-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=DNKrc5Upj5hrDIRx3inhpFd5HiToHdEW8ZG_Emb20ZU&e=">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_libcxx-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=mtIdF2_o_8CouVBz4SaIF3yVBKES8UlqBZ_lJLjroAo&s=DNKrc5Upj5hrDIRx3inhpFd5HiToHdEW8ZG_Emb20ZU&e=</a>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
</div>
</body>
</html>