[libcxx-commits] [PATCH] D57391: [libcxx] Portability fix: regex algorithms exceptions made optional.

[Andrey Maksimov via Phabricator via libcxx-commits]

amakc11 added a comment.

In D57391#1377598 <https://reviews.llvm.org/D57391#1377598>, @mclow.lists wrote:

> Other than the missing `// UNSUPPORTED` bits, this looks good to me.
>  Do you need me to commit this?


Yes. I don't have commit permissions.

> The other "exponential" tests also have a // UNSUPPORTED: c++98, c++03; but I'm not sure why.

These other "exponential" tests use `std::regex_constants::syntax_option_type` introduced in C++11. The new test I added does not use this type and associated constants, so it does not require this UNSUPPORTED directive. Besides, I made this new test consistent with all other tests in the same directory, which do not have `UNSUPPORTED: c++98, c++03` for the same reason. However, if you disagree, I will add it along with `UNSUPPORTED: libcpp-no-exceptions`, but I'd like to now the reason eventually.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57391/new/

https://reviews.llvm.org/D57391