[libcxx-commits] [PATCH] D57391: [libcxx] Portability fix: regex algorithms exceptions made optional.

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

Other than the missing `// UNSUPPORTED` bits, this looks good to me.
Do you need me to commit this?



================
Comment at: test/std/re/re.alg/re.alg.replace/exponential.pass.cpp:10
+// <regex>
+
+// template <class OutputIterator, class BidirectionalIterator,
----------------
Needs a `// UNSUPPORTED: libcpp-no-exceptions`

The other "exponential" tests also have a `// UNSUPPORTED: c++98, c++03`; but I'm not sure why. Please add it here, and I'll investigate.




Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57391/new/

https://reviews.llvm.org/D57391