[libcxx-commits] [PATCH] D66496: [libcxx] Codesign test executables if necessary

[Vedant Kumar via Phabricator via libcxx-commits]

vsk marked 2 inline comments as done.
vsk added inline comments.


================
Comment at: libcxx/utils/libcxx/test/config.py:1032-1037
+        tool_env = ''
+        if platform.system() == 'Darwin':
+            # Do not pass DYLD_LIBRARY_PATH to the compiler, linker, etc. as
+            # these tools are not meant to exercise the just-built libraries.
+            tool_env += 'DYLD_LIBRARY_PATH="" '
+
----------------
ldionne wrote:
> Just to be sure there's no subtle interaction I'm missing -- this is an entirely separate change packed into this patch, correct?
Yes. I can split this out into a separate patch if it helps. It occurred to me that this was a problem when I wrote "subprocess.call(sign_cmd, env={})" in run.py, so I thought I'd fix it everywhere in one shot.


================
Comment at: libcxx/utils/run.py:40
+
+    return subprocess.call(argv)
+
----------------
ldionne wrote:
> Why don't we instead use `sys.argv[2:]`, and avoid the funny `delete argv[0]` calls above?
Sounds good. I'll update the style in not.py as a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66496/new/

https://reviews.llvm.org/D66496