[libcxx-commits] [PATCH] D66496: [libcxx] Codesign test executables if necessary

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 29 07:34:19 PDT 2019

ldionne added inline comments.

Comment at: libcxx/test/libcxx/strings/basic.string/PR42676.sh.cpp:12
 // RUN: %cxx %flags %s -o %t.exe %compile_flags %link_flags -D_LIBCPP_HIDE_FROM_ABI_PER_TU
-// RUN: %t.exe
+// RUN: %run
Note to self and other reviewers: I checked and I don't think you missed this change in any other test -- all the other `.sh.cpp` tests already use `%run`.

Comment at: libcxx/utils/libcxx/test/config.py:1032-1037
+        tool_env = ''
+        if platform.system() == 'Darwin':
+            # Do not pass DYLD_LIBRARY_PATH to the compiler, linker, etc. as
+            # these tools are not meant to exercise the just-built libraries.
+            tool_env += 'DYLD_LIBRARY_PATH="" '
Just to be sure there's no subtle interaction I'm missing -- this is an entirely separate change packed into this patch, correct?

Comment at: libcxx/utils/run.py:40
+    return subprocess.call(argv)
Why don't we instead use `sys.argv[2:]`, and avoid the funny `delete argv[0]` calls above?



More information about the libcxx-commits mailing list