[libcxx-commits] [PATCH] D63284: [libc++] Keep __regex_word in sync with ctype_base

[Mikhail Maltsev via Phabricator via libcxx-commits]

miyuki marked an inline comment as done.
miyuki added inline comments.


================
Comment at: libcxx/trunk/include/__locale:412
+#if defined(__mips__)
+    static const mask __regex_word = static_cast<char_class_type>(_ISbit(15));
+#else
----------------
mclow.lists wrote:
> atanasyan wrote:
> > This change breaks building on mips: https://bugs.llvm.org/show_bug.cgi?id=43011
> > Maybe this change fix the problem, but I'm not an expert in libc++:
> > ```
> > static const mask __regex_word = static_cast<mask>(_ISbit(15));
> > ```
> Personally, I would lose the `_ISbit` call as well; just say `1 << 15` or `0x8000`
> We don't use `_ISbit` for the other constants, and we don't use it anywhere else in libc++.
_ISbit is endian-dependent, see https://reviews.llvm.org/D17132


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63284/new/

https://reviews.llvm.org/D63284