[libcxx-commits] [PATCH] D63284: [libc++] Keep __regex_word in sync with ctype_base
Marshall Clow via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Aug 16 07:53:15 PDT 2019
mclow.lists added inline comments.
Comment at: libcxx/trunk/include/__locale:412
+ static const mask __regex_word = static_cast<char_class_type>(_ISbit(15));
> This change breaks building on mips: https://bugs.llvm.org/show_bug.cgi?id=43011
> Maybe this change fix the problem, but I'm not an expert in libc++:
> static const mask __regex_word = static_cast<mask>(_ISbit(15));
Personally, I would lose the `_ISbit` call as well; just say `1 << 15` or `0x8000`
We don't use `_ISbit` for the other constants, and we don't use it anywhere else in libc++.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits