[libcxx-commits] [PATCH] D65365: Implement `hh_mm_ss` from P1466R3

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 6 14:14:49 PDT 2019

mclow.lists marked an inline comment as done.
mclow.lists added inline comments.

Comment at: libcxx/include/chrono:2757
+    static constexpr uint64_t __pow10(unsigned __exp)
+    {
ldionne wrote:
> mclow.lists wrote:
> > ldionne wrote:
> > > It seems like this shouldn't be reimplemented inside this class, instead we should put this at namespace scope if we don't already have something like that.
> > I put it in the class so it wouldn't be polluting the enclosing namespace.  If it's generally useful, we can promote it.
> I'd like it to be promoted so it can be tested on its own.
But it's not used anywhere else; nor really do I think it will be.
Its already tested in precision_type.pass.cpp (indirectly)



More information about the libcxx-commits mailing list