[libcxx-commits] [PATCH] D65365: Implement `hh_mm_ss` from P1466R3

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists marked 3 inline comments as done.
mclow.lists added inline comments.


================
Comment at: libcxx/include/chrono:617
+template <class Duration>
+class hh_mm_ss
+{
----------------
ldionne wrote:
> When do you plan do update the feature-test macro `__cpp_lib_chrono`?
When I get the rest of the calendaring stuff implemented.


================
Comment at: libcxx/test/std/utilities/time/time.hms/time.hms.members/hours.pass.cpp:16
+   
+// Test values
+// duration     hours   minutes seconds fractional              count
----------------
ldionne wrote:
> Can you add a comment in the other related test files saying there's a correspondence table in this file? Something like:
> 
> ```
> // See the table in hours.pass.cpp for correspondence between the magic values used below
> ```
I can do that.


================
Comment at: libcxx/test/std/utilities/time/time.hms/time.hms.nonmembers/nothing.to.do.pass.cpp:11
+
+// template <class Duration> class hh_mm_ss;
+
----------------
ldionne wrote:
> What is this testing?
Nothing. Due to historical reasons; we try not to have folders with no tests.
Probably not needed anymore, but easy to put in.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65365/new/

https://reviews.llvm.org/D65365