[libcxx-commits] [PATCH] D61275: [libcxx] Move CMake file to src, avoid using globs

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 30 12:05:39 PDT 2019


ldionne added a comment.

In D61275#1484816 <https://reviews.llvm.org/D61275#1484816>, @smeenai wrote:

> [...]
> The original plan was to use `llvm_process_sources` for that, but we couldn't do that cos libc++'s build can't rely on LLVM being around yet (though maybe we ought to reconsider that at some point with the upcoming monorepo move...). Do you think it's worth implementing that?


Whatever we do, I think it's important not to assume that all of LLVM is around for building libc++. The standalone build currently works well without LLVM around (actually, better than the non-standalone one because LLVM pollutes global CMake variables), and I think we should keep that working.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61275/new/

https://reviews.llvm.org/D61275





More information about the libcxx-commits mailing list