[libcxx-commits] [PATCH] D61275: [libcxx] Move CMake file to src, avoid using globs

[Roman Lebedev via Phabricator via libcxx-commits]

lebedev.ri added a comment.

In D61275#1484816 <https://reviews.llvm.org/D61275#1484816>, @smeenai wrote:

> Last time this came up, we wanted to implement a check to ensure no source files were forgotten, as in do a glob and compare to the explicit list of files.


Is it possible to forget a file, without it failing some lit test?
Are globs used elsewhere in llvm's cmake for this reason? I hope not. I don't remember it causing much issues.

> The original plan was to use `llvm_process_sources` for that, but we couldn't do that cos libc++'s build can't rely on LLVM being around yet (though maybe we ought to reconsider that at some point with the upcoming monorepo move...).

Passing-by 2 cent: that seems like an unreasonably high price for an insufficiently motivating reason.

> Do you think it's worth implementing that?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61275/new/

https://reviews.llvm.org/D61275