[libcxx-commits] [PATCH] D60969: [libc++][CMake] Refactor how we link against system libraries

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 22 10:17:26 PDT 2019


ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/lib/CMakeLists.txt:394
-# it. This is not necessarily the cleanest solution.
-set(LIBCXX_LIBRARIES ${LIBCXX_LIBRARIES} PARENT_SCOPE)
----------------
This is now handled by CMake automatically, because benchmarks link against `cxx_shared` or `cxx_static`, and those have `PUBLIC` link dependencies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60969/new/

https://reviews.llvm.org/D60969





More information about the libcxx-commits mailing list