[libcxx-commits] [PATCH] D60969: [libc++][CMake] Refactor how we link against system libraries

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added reviewers: phosek, smeenai.
Herald added subscribers: libcxx-commits, mstorsjo, jfb, dexonsmith, jkorous, christof, mgorny.
Herald added a reviewer: EricWF.
Herald added a project: libc++.
ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/lib/CMakeLists.txt:394
-# it. This is not necessarily the cleanest solution.
-set(LIBCXX_LIBRARIES ${LIBCXX_LIBRARIES} PARENT_SCOPE)
----------------
This is now handled by CMake automatically, because benchmarks link against `cxx_shared` or `cxx_static`, and those have `PUBLIC` link dependencies.


Instead of populating the global LIBCXX_LIBRARIES, we use the link-time
dependency management built into CMake to propagate link flags. This
leads to a cleaner and easier-to-follow build.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60969

Files:
  libcxx/benchmarks/CMakeLists.txt
  libcxx/cmake/Modules/HandleLibcxxFlags.cmake
  libcxx/lib/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60969.196088.patch
Type: text/x-patch
Size: 7498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190422/f4a60c60/attachment.bin>