[libcxx-commits] [PATCH] D60540: [libc++] Make sure we don't eagerly diagnose non-const comparators for containers of incomplete types
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Apr 10 22:25:19 PDT 2019
EricWF added inline comments.
================
Comment at: libcxx/test/libcxx/containers/unord/non_const_comparator.pass.cpp:41-42
+ // expected-no-disagnostics
+ test<std::unordered_set>();
+ test<std::unordered_multiset>();
+ test<std::unordered_map>();
----------------
zoecarver wrote:
> ldionne wrote:
> > Note: those two tests fail, I need to figure out why (tomorrow). I still wanted to get the patch out there to get feedback if there's any.
> Looked into it a bit but can't seem to figure it out either 😕. My //guess// is that `__check_hash_requirements` is being called before `Derived` is completed (somehow).
The map tests are incorrect. They pass `Derived*` as the key type and `std::less<Base*>` as the value type. That might be why they're passing but the `set` tests are not.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60540/new/
https://reviews.llvm.org/D60540
More information about the libcxx-commits
mailing list