[libcxx-commits] [PATCH] D60540: [libc++] Make sure we don't eagerly diagnose non-const comparators for containers of incomplete types

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/test/libcxx/containers/unord/non_const_comparator.pass.cpp:41-42
+  // expected-no-disagnostics
+  test<std::unordered_set>();
+  test<std::unordered_multiset>();
+  test<std::unordered_map>();
----------------
ldionne wrote:
> Note: those two tests fail, I need to figure out why (tomorrow). I still wanted to get the patch out there to get feedback if there's any.
Looked into it a bit but can't seem to figure it out either 😕. My //guess// is that `__check_hash_requirements` is being called before `Derived` is completed (somehow).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60540/new/

https://reviews.llvm.org/D60540