[libcxx-commits] [PATCH] D60166: [libc++abi] Refactor CMake build to avoid object libraries

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: libcxxabi/src/CMakeLists.txt:206
+    if(LIBUNWIND_HERMETIC_STATIC_LIBRARY)
+      target_sources(cxxabi_static PRIVATE $<TARGET_OBJECTS:unwind_static_objects>)
+    else()
----------------
Will you want to do something similar with libunwind (where it's not build as an object library anymore), at which point this logic will change too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60166/new/

https://reviews.llvm.org/D60166