[libcxx-commits] [PATCH] D60166: [libc++abi] Refactor CMake build to avoid object libraries

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxxabi/src/CMakeLists.txt:205
+      (TARGET unwind_static OR HAVE_LIBUNWIND))
+    if(LIBUNWIND_HERMETIC_STATIC_LIBRARY)
+      target_sources(cxxabi_static PRIVATE $<TARGET_OBJECTS:unwind_static_objects>)
----------------
I want to mention that assuming that `LIBUNWIND_XXX` is defined here is pretty bad, as it means none of this works unless libc++abi and libunwind are actually subprojects of the same CMake project. This is a pre-existing condition, but it's not great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60166/new/

https://reviews.llvm.org/D60166