[libcxx-commits] [PATCH] D60114: [CMake] Differentiate between static and shared libc++abi

[Petr Hosek via Phabricator via libcxx-commits]

phosek marked an inline comment as done.
phosek added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:110-114
   if (LIBCXX_CXX_ABI_SYSTEM)
     set(HEADERS "")
+  else()
+    set(HEADERS "cxxabi.h;__cxxabi_config.h")
   endif()
----------------
Hahnfeld wrote:
> Does it make sense to move these lines into the above `if (LIBCXX_CXX_ABI_INTREE)`? If I understand the code correctly, `LIBCXX_CXX_ABI_INTREE` and `LIBCXX_CXX_ABI_SYSTEM` are mutually exclusive, no?
I'm not sure if that was the intention, but it's not how things are set up right now, e.g. for [FreeBSD](https://github.com/llvm/llvm-project/blob/master/libcxx/CMakeLists.txt#L164) or [default](https://github.com/llvm/llvm-project/blob/master/libcxx/CMakeLists.txt#L168) we set neither of these variables. This is probably something we should also consider cleaning up in the future.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60114/new/

https://reviews.llvm.org/D60114