[libcxx-commits] [PATCH] D60114: [CMake] Differentiate between static and shared libc++abi

[Jonas Hahnfeld via Phabricator via libcxx-commits]

Hahnfeld accepted this revision.
Hahnfeld added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:110-114
   if (LIBCXX_CXX_ABI_SYSTEM)
     set(HEADERS "")
+  else()
+    set(HEADERS "cxxabi.h;__cxxabi_config.h")
   endif()
----------------
Does it make sense to move these lines into the above `if (LIBCXX_CXX_ABI_INTREE)`? If I understand the code correctly, `LIBCXX_CXX_ABI_INTREE` and `LIBCXX_CXX_ABI_SYSTEM` are mutually exclusive, no?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60114/new/

https://reviews.llvm.org/D60114