[PATCH] D54726: [libcxx] Support generating linker script for static library

Petr Hosek via Phabricator reviews at reviews.llvm.org
Mon Nov 19 15:49:03 PST 2018

phosek added inline comments.

Comment at: libcxx/utils/gen_link_script.py:11
+import argparse
 import os
ldionne wrote:
> Can you confirm that there are no functional changes beyond adding support for a custom output file in this script? This is only a refactoring (thanks!), or did I miss something?
The original script did not support creating a linker script for static library, so there's a functional change, but I also refactored the code a bit to make it (subjectively) simpler. I'd be fine doing the refactoring as a separate change if you prefer?

  rCXX libc++


More information about the libcxx-commits mailing list