[PATCH] D48669: [pair] Mark constructors as conditionally noexcept

Louis Dionne via Phabricator reviews at reviews.llvm.org
Thu Dec 6 09:48:24 PST 2018


ldionne added a comment.

In D48669#1320853 <https://reviews.llvm.org/D48669#1320853>, @mclow.lists wrote:

> I checked both N4788 and N4788, and couldn't find any conditional noexcept on the constructors of `pair`.
>  Just `explicit(see below) constexpr pair(const T1& x, const T2& y);`
>
> So I'm assuming that this is a conforming extension. 
>  If so, I'm ok with that - but then the tests need to be libc++ specific.


Yes, it is an extension. Sorry, I should have caught that myself. This patch dates from a while back when I still didn't know the difference between `test/libcxx` and `test/std`. I'll fix it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48669/new/

https://reviews.llvm.org/D48669





More information about the libcxx-commits mailing list