[PATCH] D48669: [pair] Mark constructors as conditionally noexcept

Wed Dec 5 17:33:37 PST 2018

mclow.lists added a comment.

I checked both N4788 and N4788, and couldn't find any conditional noexcept on the constructors of `pair`.
Just `explicit(see below) constexpr pair(const T1& x, const T2& y);`

So I'm assuming that this is a conforming extension. 
If so, I'm ok with that - but then the tests need to be libc++ specific.
They can either be split out and the new parts moved into `test/libcxx`, or the `static_assert`s can be changed to `LIBCPP_STATIC_ASSERT`s.
Given the amount of new tests, I'm leaning towards the first option.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48669/new/

https://reviews.llvm.org/D48669