[Libclc-dev] [PATCH] integer: remove explicit casts from _MIN definitions

[Tom Stellard via Libclc-dev]

On Fri, Oct 02, 2015 at 10:48:10AM -0500, Aaron Watry via Libclc-dev wrote:
> The spec says (section 6.12.3, CL version 1.2):
>   The macro names given in the following list must use the values
>   specified. The values shall all be constant expressions suitable
>   for use in #if preprocessing directives.
> 

LGTM.

Sorry, I was the one who suggested the casts.

-Tom

> This commit addresses the second part of that statement.
> 
> CC: Jan Vesely <jan.vesely at rutgers.edu>
> CC: Moritz Pflanzer <moritz.pflanzer14 at imperial.ac.uk>
> CC: Serge Martin <edb+libclc at sigluy.net>
> ---
>  generic/include/clc/integer/definitions.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/generic/include/clc/integer/definitions.h b/generic/include/clc/integer/definitions.h
> index 89de232..0079c30 100644
> --- a/generic/include/clc/integer/definitions.h
> +++ b/generic/include/clc/integer/definitions.h
> @@ -1,14 +1,14 @@
>  #define CHAR_BIT 8
>  #define INT_MAX 2147483647
> -#define INT_MIN ((int)(-2147483647 - 1))
> +#define INT_MIN (-2147483647 - 1)
>  #define LONG_MAX  0x7fffffffffffffffL
>  #define LONG_MIN (-0x7fffffffffffffffL - 1)
>  #define CHAR_MAX SCHAR_MAX
>  #define CHAR_MIN SCHAR_MIN
>  #define SCHAR_MAX 127
> -#define SCHAR_MIN ((char)(-127 - 1))
> +#define SCHAR_MIN (-127 - 1)
>  #define SHRT_MAX 32767
> -#define SHRT_MIN ((short)(-32767 - 1))
> +#define SHRT_MIN (-32767 - 1)
>  #define UCHAR_MAX 255
>  #define USHRT_MAX 65535
>  #define UINT_MAX 0xffffffff
> -- 
> 2.1.4
> 
> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev