[Libclc-dev] [PATCH] integer: remove explicit casts from _MIN definitions

Aaron Watry via Libclc-dev libclc-dev at lists.llvm.org
Fri Oct 2 08:48:10 PDT 2015


The spec says (section 6.12.3, CL version 1.2):
  The macro names given in the following list must use the values
  specified. The values shall all be constant expressions suitable
  for use in #if preprocessing directives.

This commit addresses the second part of that statement.

CC: Jan Vesely <jan.vesely at rutgers.edu>
CC: Moritz Pflanzer <moritz.pflanzer14 at imperial.ac.uk>
CC: Serge Martin <edb+libclc at sigluy.net>
---
 generic/include/clc/integer/definitions.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/generic/include/clc/integer/definitions.h b/generic/include/clc/integer/definitions.h
index 89de232..0079c30 100644
--- a/generic/include/clc/integer/definitions.h
+++ b/generic/include/clc/integer/definitions.h
@@ -1,14 +1,14 @@
 #define CHAR_BIT 8
 #define INT_MAX 2147483647
-#define INT_MIN ((int)(-2147483647 - 1))
+#define INT_MIN (-2147483647 - 1)
 #define LONG_MAX  0x7fffffffffffffffL
 #define LONG_MIN (-0x7fffffffffffffffL - 1)
 #define CHAR_MAX SCHAR_MAX
 #define CHAR_MIN SCHAR_MIN
 #define SCHAR_MAX 127
-#define SCHAR_MIN ((char)(-127 - 1))
+#define SCHAR_MIN (-127 - 1)
 #define SHRT_MAX 32767
-#define SHRT_MIN ((short)(-32767 - 1))
+#define SHRT_MIN (-32767 - 1)
 #define UCHAR_MAX 255
 #define USHRT_MAX 65535
 #define UINT_MAX 0xffffffff
-- 
2.1.4



More information about the Libclc-dev mailing list