[Libclc-dev] [PATCH 2/3] r600: get_work_dim: Update metadata syntax for LLVM 3.6

Jeroen Ketema j.ketema at imperial.ac.uk
Thu Dec 25 07:13:33 PST 2014


> On 24 Dec 2014, at 16:22, Aaron Watry <awatry at gmail.com> wrote:
> 
> 
> On Dec 24, 2014 1:53 AM, "Jan Vesely" <jan.vesely at rutgers.edu <mailto:jan.vesely at rutgers.edu>> wrote:
> >
> > On Tue, 2014-12-23 at 12:51 -0500, Tom Stellard wrote:
> > > ---
> > >  r600/lib/workitem/get_work_dim.ll | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/r600/lib/workitem/get_work_dim.ll b/r600/lib/workitem/get_work_dim.ll
> > > index 1220153..1f86b5e 100644
> > > --- a/r600/lib/workitem/get_work_dim.ll
> > > +++ b/r600/lib/workitem/get_work_dim.ll
> > > @@ -5,4 +5,4 @@ define i32 @get_work_dim() nounwind readnone alwaysinline {
> > >    ret i32 %x
> > >  }
> > >
> > > -!0 = metadata !{ i32 1, i32 4 }
> > > +!0 = !{ i32 1, i32 4 }
> >
> > the first two LGTM,
> > I don't know enough to review the third one
> 
> Likewise. 
> 
> Is this the only builtin that needs updating at this time, or just the only one updated here? 
> 
This is the only file with metadata in it.

Looks good to me too.

Jeroen
> I'd check now, but I'm on a cell phone at the parents house right now and don't want to forget to check when by a computer later.
> 
> --Aaron
> 
> > --
> > Jan Vesely <jan.vesely at rutgers.edu <mailto:jan.vesely at rutgers.edu>>
> >
> > _______________________________________________
> > Libclc-dev mailing list
> > Libclc-dev at pcc.me.uk <mailto:Libclc-dev at pcc.me.uk>
> > http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev <http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev>
> >
> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at pcc.me.uk
> http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20141225/c172b272/attachment.html>


More information about the Libclc-dev mailing list