<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 24 Dec 2014, at 16:22, Aaron Watry <<a href="mailto:awatry@gmail.com" class="">awatry@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p dir="ltr" class=""><br class="">
On Dec 24, 2014 1:53 AM, "Jan Vesely" <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a>> wrote:<br class="">
><br class="">
> On Tue, 2014-12-23 at 12:51 -0500, Tom Stellard wrote:<br class="">
> > ---<br class="">
> > r600/lib/workitem/get_work_dim.ll | 2 +-<br class="">
> > 1 file changed, 1 insertion(+), 1 deletion(-)<br class="">
> ><br class="">
> > diff --git a/r600/lib/workitem/get_work_dim.ll b/r600/lib/workitem/get_work_dim.ll<br class="">
> > index 1220153..1f86b5e 100644<br class="">
> > --- a/r600/lib/workitem/get_work_dim.ll<br class="">
> > +++ b/r600/lib/workitem/get_work_dim.ll<br class="">
> > @@ -5,4 +5,4 @@ define i32 @get_work_dim() nounwind readnone alwaysinline {<br class="">
> > ret i32 %x<br class="">
> > }<br class="">
> ><br class="">
> > -!0 = metadata !{ i32 1, i32 4 }<br class="">
> > +!0 = !{ i32 1, i32 4 }<br class="">
><br class="">
> the first two LGTM,<br class="">
> I don't know enough to review the third one</p><p dir="ltr" class="">Likewise. </p><p dir="ltr" class="">Is this the only builtin that needs updating at this time, or just the only one updated here? </p></div></blockquote><div>This is the only file with metadata in it.</div><div><br class=""></div><div>Looks good to me too.</div><div><br class=""></div><div>Jeroen</div><blockquote type="cite" class=""><div class=""><p dir="ltr" class="">I'd check now, but I'm on a cell phone at the parents house right now and don't want to forget to check when by a computer later.</p><p dir="ltr" class="">--Aaron</p><p dir="ltr" class="">> --<br class="">
> Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a>><br class="">
><br class="">
> _______________________________________________<br class="">
> Libclc-dev mailing list<br class="">
> <a href="mailto:Libclc-dev@pcc.me.uk" class="">Libclc-dev@pcc.me.uk</a><br class="">
> <a href="http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev" class="">http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev</a><br class="">
><br class="">
</p>
_______________________________________________<br class="">Libclc-dev mailing list<br class=""><a href="mailto:Libclc-dev@pcc.me.uk" class="">Libclc-dev@pcc.me.uk</a><br class="">http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev<br class=""></div></blockquote></div><br class=""></body></html>