[libc-commits] [libc] [libc][math] Qualify ceil functions to constexpr (PR #184948)

[via libc-commits]

================
@@ -454,7 +507,6 @@ TEST(LlvmLibcSharedMathTest, AllBFloat16) {
   EXPECT_FP_EQ(bfloat16(5.0), LIBC_NAMESPACE::shared::bf16addl(2L, 3L));
   EXPECT_FP_EQ(bfloat16(10.0),
                LIBC_NAMESPACE::shared::bf16fmaf(2.0f, 3.0f, 4.0f));
-  EXPECT_FP_EQ(bfloat16(0.0), LIBC_NAMESPACE::shared::ceilbf16(bfloat16(0.0)));
----------------
lntue wrote:

This test is to make sure that the shared parts are still working with compilers and settings that are not supported by the whole LLVM libc, only by shared parts.  And since now we have 2 different code paths for 2 different contexts that are accessible, we should test both to make sure there are no regression.  Duplicated tests for different settings and environments are not an issue.  Letting regression slip through due to under-testing is a bigger issue.

https://github.com/llvm/llvm-project/pull/184948