[libc-commits] [libc] [libc][math] Qualify ceil functions to constexpr (PR #184948)

Muhammad Bassiouni via libc-commits libc-commits at lists.llvm.org
Sun Mar 22 22:05:42 PDT 2026


================
@@ -454,7 +507,6 @@ TEST(LlvmLibcSharedMathTest, AllBFloat16) {
   EXPECT_FP_EQ(bfloat16(5.0), LIBC_NAMESPACE::shared::bf16addl(2L, 3L));
   EXPECT_FP_EQ(bfloat16(10.0),
                LIBC_NAMESPACE::shared::bf16fmaf(2.0f, 3.0f, 4.0f));
-  EXPECT_FP_EQ(bfloat16(0.0), LIBC_NAMESPACE::shared::ceilbf16(bfloat16(0.0)));
----------------
bassiounix wrote:

We already have tests for those functions, so what's the point of having a duplicate test here too?
What we intended with these test is to make sure that they run in a `constexpr` context.
I think if there was any failures in the internal implementation it would be caught by the other tests.

https://github.com/llvm/llvm-project/pull/184948


More information about the libc-commits mailing list