[libc-commits] [libc] [libc] Add -Werror for libc tests (PR #160413)

Wed Oct 22 12:01:21 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `libc` at step 10 "Add check check-libc-amdgcn-amd-amdhsa".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/15943

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 10 (Add check check-libc-amdgcn-amd-amdhsa) failure: test (failure)
...
[600/3299] Linking CXX static library libc/test/src/__support/liblibc.test.src.__support.arg_list_test.__hermetic__.libc.a
[601/3299] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.bf16fma.__internal__.dir/bf16fma.cpp.o
[602/3299] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.bf16fmaf.__internal__.dir/bf16fmaf.cpp.o
[603/3299] Linking CXX static library libc/test/src/__support/liblibc.test.src.__support.wcs_to_integer_test.__hermetic__.libc.a
[604/3299] Linking CXX static library libc/test/src/__support/liblibc.test.src.__support.big_int_test.__hermetic__.libc.a
[605/3299] Linking CXX static library libc/test/src/__support/liblibc.test.src.__support.integer_literals_test.__hermetic__.libc.a
[606/3299] Linking CXX static library libc/test/src/__support/liblibc.test.src.__support.fixedvector_test.__hermetic__.libc.a
[607/3299] Linking CXX static library libc/test/src/__support/liblibc.test.src.__support.char_vector_test.__hermetic__.libc.a
[608/3299] Linking CXX static library libc/test/src/__support/liblibc.test.src.__support.memory_size_test.__hermetic__.libc.a
[609/3299] Building CXX object libc/test/UnitTest/CMakeFiles/LibcFPTestHelpers.hermetic.dir/FEnvSafeTest.cpp.o
FAILED: libc/test/UnitTest/CMakeFiles/LibcFPTestHelpers.hermetic.dir/FEnvSafeTest.cpp.o 
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/./bin/clang++ --target=amdgcn-amd-amdhsa -DLIBC_NAMESPACE=__llvm_libc_22_0_0_git -DTARGET_SUPPORTS_CLOCK -D__LIBC_USE_FLOAT16_CONVERSION -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include/amdgcn-amd-amdhsa -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -UNDEBUG --target=amdgcn-amd-amdhsa -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT "-DLIBC_MATH=(LIBC_MATH_SKIP_ACCURATE_PASS | LIBC_MATH_INTERMEDIATE_COMP_IN_FLOAT | LIBC_MATH_SMALL_TABLES | LIBC_MATH_NO_ERRNO | LIBC_MATH_NO_EXCEPT)" -fno-math-errno -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_SHARED -DLIBC_THREAD_MODE=LIBC_THREAD_MODE_SINGLE -DLIBC_TARGET_OS_IS_GPU -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ffixed-point -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -DLIBC_TEST=HERMETIC -Wno-multi-gpu -nogpulib -mcpu=native -flto -mcode-object-version=6 -nostdinc++ -MD -MT libc/test/UnitTest/CMakeFiles/LibcFPTestHelpers.hermetic.dir/FEnvSafeTest.cpp.o -MF libc/test/UnitTest/CMakeFiles/LibcFPTestHelpers.hermetic.dir/FEnvSafeTest.cpp.o.d -o libc/test/UnitTest/CMakeFiles/LibcFPTestHelpers.hermetic.dir/FEnvSafeTest.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/UnitTest/FEnvSafeTest.cpp
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/UnitTest/FEnvSafeTest.cpp:44:49: error: unused parameter 'before_fenv' [-Werror,-Wunused-parameter]
   44 | void FEnvSafeTest::expect_fenv_eq(const fenv_t &before_fenv,
      |                                                 ^
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/libc/test/UnitTest/FEnvSafeTest.cpp:45:49: error: unused parameter 'after_fenv' [-Werror,-Wunused-parameter]
   45 |                                   const fenv_t &after_fenv) {
      |                                                 ^
2 errors generated.
[610/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.array_test.__hermetic__.libc.a
[611/3299] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.rintbf16_test.__hermetic__.__build__.dir/rintbf16_test.cpp.o
[612/3299] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.remquol_test.__hermetic__.__build__.dir/remquol_test.cpp.o
[613/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.bit_test.__hermetic__.libc.a
[614/3299] Building CXX object libc/test/src/stdbit/CMakeFiles/libc.test.src.stdbit.stdc_has_single_bit_ull_test.__hermetic__.__build__.dir/stdc_has_single_bit_ull_test.cpp.o
[615/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.cstddef_test.__hermetic__.libc.a
[616/3299] Linking CXX static library libc/test/src/ctype/liblibc.test.src.ctype.islower_test.__hermetic__.libc.a
[617/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.bitset_test.__hermetic__.libc.a
[618/3299] Building CXX object libc/test/UnitTest/CMakeFiles/LibcTest.hermetic.dir/LibcTestMain.cpp.o
[619/3299] Building CXX object libc/test/UnitTest/CMakeFiles/LibcTest.hermetic.dir/CmakeFilePath.cpp.o
[620/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.stringview_test.__hermetic__.libc.a
[621/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.mutex_test.__hermetic__.libc.a
[622/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.limits_test.__hermetic__.libc.a
[623/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.atomic_test.__hermetic__.libc.a
[624/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.int_seq_test.__hermetic__.libc.a
[625/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.stringstream_test.__hermetic__.libc.a
[626/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.tuple_test.__hermetic__.libc.a
[627/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.optional_test.__hermetic__.libc.a
[628/3299] Building CXX object libc/test/src/stdbit/CMakeFiles/libc.test.src.stdbit.stdc_has_single_bit_ul_test.__hermetic__.__build__.dir/stdc_has_single_bit_ul_test.cpp.o
[629/3299] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.remquof16_test.__hermetic__.__build__.dir/remquof16_test.cpp.o
[630/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.span_test.__hermetic__.libc.a
[631/3299] Linking CXX static library libc/test/src/math/smoke/liblibc.test.src.math.smoke.roundevenf16_test.__hermetic__.libc.a
[632/3299] Building CXX object libc/test/src/stdio/CMakeFiles/libc.test.src.stdio.puts_test.__hermetic__.__build__.dir/puts_test.cpp.o
[633/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.type_traits_test.__hermetic__.libc.a
[634/3299] Linking CXX static library libc/test/src/__support/CPP/liblibc.test.src.__support.CPP.string_test.__hermetic__.libc.a
[635/3299] Linking CXX static library libc/test/src/math/smoke/liblibc.test.src.math.smoke.atanf16_test.__hermetic__.libc.a
[636/3299] Building CXX object libc/test/src/string/CMakeFiles/libc.test.src.string.strncpy_test.__hermetic__.__build__.dir/strncpy_test.cpp.o
[637/3299] Building CXX object libc/test/UnitTest/CMakeFiles/LibcMemoryHelpers.hermetic.dir/MemoryMatcher.cpp.o
[638/3299] Building CXX object libc/src/math/generic/CMakeFiles/libc.src.math.generic.bf16fmal.__internal__.dir/bf16fmal.cpp.o
[639/3299] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.iscntrl_test.__hermetic__.__build__.dir/iscntrl_test.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/160413