[libc-commits] [libc] [libc] Add -Werror for libc tests (PR #160413)

Wed Oct 22 11:34:58 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `libc-aarch64-ubuntu-fullbuild-dbg` running on `libc-aarch64-ubuntu` while building `libc` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/71/builds/33970

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
@@@BUILD_STEP libc-unit-tests@@@
Running: ninja libc-unit-tests
[1/3092] Building CXX object libc/test/src/__support/wchar/CMakeFiles/libc.test.src.__support.wchar.utf8_to_32_test.__unit__.__build__.dir/utf8_to_32_test.cpp.o
[2/3092] Building CXX object libc/test/src/__support/wchar/CMakeFiles/libc.test.src.__support.wchar.string_converter_test.__unit__.__build__.dir/string_converter_test.cpp.o
[3/3092] Building CXX object libc/test/src/__support/wchar/CMakeFiles/libc.test.src.__support.wchar.utf32_to_8_test.__unit__.__build__.dir/utf32_to_8_test.cpp.o
[4/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o
[5/3092] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjf_test.__unit__.__build__.dir/conjf_test.cpp.o
[6/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fmaxf16_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmaxf16_test.cpp.o
[7/3092] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cprojf128_test.__unit__.__build__.dir/cprojf128_test.cpp.o
[8/3092] Building CXX object libc/test/src/__support/HashTable/CMakeFiles/libc.test.src.__support.HashTable.bitmask_test.__unit__.__build__.dir/bitmask_test.cpp.o
FAILED: libc/test/src/__support/HashTable/CMakeFiles/libc.test.src.__support.HashTable.bitmask_test.__unit__.__build__.dir/bitmask_test.cpp.o 
/usr/bin/clang++ -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -D_DEBUG -I/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc -isystem libc/include -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wno-pass-failed -fdiagnostics-color -g -DLIBC_QSORT_IMPL=LIBC_QSORT_QUICK_SORT -DLIBC_ADD_NULL_CHECKS -DLIBC_ERRNO_MODE=LIBC_ERRNO_MODE_DEFAULT -DLIBC_THREAD_MODE=LIBC_THREAD_MODE_PLATFORM -fpie -DLIBC_FULL_BUILD -ffreestanding -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wimplicit-fallthrough -Wwrite-strings -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wstrict-prototypes -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wthread-safety -DLIBC_TEST=UNIT -std=gnu++17 -MD -MT libc/test/src/__support/HashTable/CMakeFiles/libc.test.src.__support.HashTable.bitmask_test.__unit__.__build__.dir/bitmask_test.cpp.o -MF libc/test/src/__support/HashTable/CMakeFiles/libc.test.src.__support.HashTable.bitmask_test.__unit__.__build__.dir/bitmask_test.cpp.o.d -o libc/test/src/__support/HashTable/CMakeFiles/libc.test.src.__support.HashTable.bitmask_test.__unit__.__build__.dir/bitmask_test.cpp.o -c /home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/__support/HashTable/bitmask_test.cpp
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/__support/HashTable/bitmask_test.cpp:44:18: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
    Iter iter = {data};
                 ^~~~
                 {   }
/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-project/libc/test/src/__support/HashTable/bitmask_test.cpp:59:18: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
    Iter iter = {data};
                 ^~~~
                 {   }
2 errors generated.
[9/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.ldexpl_test.__unit__.__build__.dir/ldexpl_test.cpp.o
[10/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.nextafter_test.__unit__.__build__.dir/nextafter_test.cpp.o
[11/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.nextafterf_test.__unit__.__build__.dir/nextafterf_test.cpp.o
[12/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fmaximum_mag_numl_test.__unit__.__build__.dir/fmaximum_mag_numl_test.cpp.o
[13/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.fmax_test.__unit__.__build__.dir/fmax_test.cpp.o
[14/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fmul_test.__unit__.__build__.dir/fmul_test.cpp.o
[15/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fmaxbf16_test.__unit__.__build__.dir/fmaxbf16_test.cpp.o
[16/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.copysignf_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/copysignf_test.cpp.o
[17/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fabsf_test.__unit__.__build__.dir/fabsf_test.cpp.o
[18/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.nextafterl_test.__unit__.__build__.dir/nextafterl_test.cpp.o
[19/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fmaximum_mag_numf16_test.__unit__.__build__.dir/fmaximum_mag_numf16_test.cpp.o
[20/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.canonicalizef16_test.__unit__.__build__.dir/canonicalizef16_test.cpp.o
[21/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fmax_test.__unit__.__NO_MISC_MATH_BASIC_OPS_OPT.__build__.dir/fmax_test.cpp.o
[22/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.fmin_test.__unit__.__build__.dir/fmin_test.cpp.o
[23/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.sinpif_test.__unit__.__build__.dir/sinpif_test.cpp.o
[24/3092] Building CXX object libc/test/src/math/CMakeFiles/libc.test.src.math.modfl_test.__unit__.__build__.dir/modfl_test.cpp.o
[25/3092] Building CXX object libc/test/src/math/smoke/CMakeFiles/libc.test.src.math.smoke.ceill_test.__unit__.__build__.dir/ceill_test.cpp.o
ninja: build stopped: subcommand failed.
['ninja', 'libc-unit-tests'] exited with return code 1.
The build step threw an exception...
Traceback (most recent call last):
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 181, in step
    yield
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 154, in main
    run_command(['ninja', 'libc-unit-tests'])
  File "../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py", line 196, in run_command
    util.report_run_cmd(cmd, cwd=directory)
  File "/home/libc-buildbot/libc-aarch64-ubuntu/libc-aarch64-ubuntu-fullbuild-dbg/llvm-zorg/zorg/buildbot/builders/annotated/util.py", line 49, in report_run_cmd

```

</details>

https://github.com/llvm/llvm-project/pull/160413