[libc-commits] [libc] libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (PR #126359)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Sun Feb 9 14:13:23 PST 2025


================
@@ -51,7 +51,11 @@ set(LIBC_KERNEL_HEADERS "/usr/include" CACHE STRING "Path to Linux kernel header
 # Defining a global namespace to enclose all libc functions.
 set(default_namespace "__llvm_libc")
 if(LLVM_VERSION_MAJOR)
-  string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX ${LLVM_VERSION_SUFFIX})
+  if(DEFINED LLVM_VERSION_SUFFIX AND NOT "${LLVM_VERSION_SUFFIX}" STREQUAL "")
+    string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX "${LLVM_VERSION_SUFFIX}")
+  else()
+    set(NS_LLVM_VERSION_SUFFIX "")
+  endif()
----------------
jhuber6 wrote:

```suggestion
  string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX "${LLVM_VERSION_SUFFIX}")
```
Does this not work?

https://github.com/llvm/llvm-project/pull/126359


More information about the libc-commits mailing list