[libc-commits] [libc] libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (PR #126359)
via libc-commits
libc-commits at lists.llvm.org
Sat Feb 8 00:23:21 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Sylvestre Ledru (sylvestre)
<details>
<summary>Changes</summary>
Closes: #<!-- -->126358
cc @<!-- -->samvangysegem
---
Full diff: https://github.com/llvm/llvm-project/pull/126359.diff
1 Files Affected:
- (modified) libc/CMakeLists.txt (+5-1)
``````````diff
diff --git a/libc/CMakeLists.txt b/libc/CMakeLists.txt
index 1c4c0cd5aa22ba..d44769721c918f 100644
--- a/libc/CMakeLists.txt
+++ b/libc/CMakeLists.txt
@@ -51,7 +51,11 @@ set(LIBC_KERNEL_HEADERS "/usr/include" CACHE STRING "Path to Linux kernel header
# Defining a global namespace to enclose all libc functions.
set(default_namespace "__llvm_libc")
if(LLVM_VERSION_MAJOR)
- string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX ${LLVM_VERSION_SUFFIX})
+ if(DEFINED LLVM_VERSION_SUFFIX AND NOT "${LLVM_VERSION_SUFFIX}" STREQUAL "")
+ string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX "${LLVM_VERSION_SUFFIX}")
+ else()
+ set(NS_LLVM_VERSION_SUFFIX "")
+ endif()
set(default_namespace "__llvm_libc_${LLVM_VERSION_MAJOR}_${LLVM_VERSION_MINOR}_${LLVM_VERSION_PATCH}_${NS_LLVM_VERSION_SUFFIX}")
endif()
set(LIBC_NAMESPACE ${default_namespace}
``````````
</details>
https://github.com/llvm/llvm-project/pull/126359
More information about the libc-commits
mailing list