[libc-commits] [libc] [libc] create TimeReader to look at a struct tm (PR #126138)
Nick Desaulniers via libc-commits
libc-commits at lists.llvm.org
Thu Feb 6 14:32:46 PST 2025
================
@@ -15,6 +15,98 @@
namespace LIBC_NAMESPACE_DECL {
namespace time_utils {
+// TODO: clean this up in a followup patch
+int64_t mktime_internal(const struct tm *tm_out) {
----------------
nickdesaulniers wrote:
mind including stdint.h since you're using int64_t?
Also, @lntue reminded me recently that the `struct` and `class` keywords are optional in C++. Let's use them in user facing headers, but internally, under src/, let's not? You elide it in other files below.
https://github.com/llvm/llvm-project/pull/126138
More information about the libc-commits
mailing list