[libc-commits] [libc] [libc] Fix path to fcntl_overlay in cmake (PR #114464)

via libc-commits libc-commits at lists.llvm.org
Thu Oct 31 13:54:46 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

<details>
<summary>Changes</summary>

The proxy header definition for mode_t was using an incorrect form for
its dependency on fcntl_overlay. The relative paths for dependencies can
only go down, not up so "../" doesn't work. This patch fixes it to be
absolute.


---
Full diff: https://github.com/llvm/llvm-project/pull/114464.diff


1 Files Affected:

- (modified) libc/hdr/types/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/libc/hdr/types/CMakeLists.txt b/libc/hdr/types/CMakeLists.txt
index e45979857d7955..5ad71e7a6ff46c 100644
--- a/libc/hdr/types/CMakeLists.txt
+++ b/libc/hdr/types/CMakeLists.txt
@@ -51,7 +51,7 @@ add_proxy_header_library(
   HDRS
     mode_t.h
   DEPENDS
-    ../fcntl_overlay
+    libc.hdr.fcntl_overlay
   FULL_BUILD_DEPENDS
     libc.include.llvm-libc-types.mode_t
     libc.include.fcntl

``````````

</details>


https://github.com/llvm/llvm-project/pull/114464


More information about the libc-commits mailing list