[libc-commits] [libc] [libc] Fix path to fcntl_overlay in cmake (PR #114464)

Michael Jones via libc-commits libc-commits at lists.llvm.org
Thu Oct 31 13:54:11 PDT 2024


https://github.com/michaelrj-google created https://github.com/llvm/llvm-project/pull/114464

The proxy header definition for mode_t was using an incorrect form for
its dependency on fcntl_overlay. The relative paths for dependencies can
only go down, not up so "../" doesn't work. This patch fixes it to be
absolute.


>From 3a15a3f5fabfe527fe442268778a82e9c607649b Mon Sep 17 00:00:00 2001
From: Michael Jones <michaelrj at google.com>
Date: Thu, 31 Oct 2024 13:52:02 -0700
Subject: [PATCH] [libc] Fix path to fcntl_overlay in cmake

The proxy header definition for mode_t was using an incorrect form for
its dependency on fcntl_overlay. The relative paths for dependencies can
only go down, not up so "../" doesn't work. This patch fixes it to be
absolute.
---
 libc/hdr/types/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libc/hdr/types/CMakeLists.txt b/libc/hdr/types/CMakeLists.txt
index e45979857d7955..5ad71e7a6ff46c 100644
--- a/libc/hdr/types/CMakeLists.txt
+++ b/libc/hdr/types/CMakeLists.txt
@@ -51,7 +51,7 @@ add_proxy_header_library(
   HDRS
     mode_t.h
   DEPENDS
-    ../fcntl_overlay
+    libc.hdr.fcntl_overlay
   FULL_BUILD_DEPENDS
     libc.include.llvm-libc-types.mode_t
     libc.include.fcntl



More information about the libc-commits mailing list