[libc-commits] [libc] [libc][i386] FPBit support for 96b long double (PR #115084)
Nick Desaulniers via libc-commits
libc-commits at lists.llvm.org
Wed Nov 6 09:12:44 PST 2024
================
@@ -127,7 +127,11 @@ template <> struct FPLayout<FPType::IEEE754_Binary128> {
};
template <> struct FPLayout<FPType::X86_Binary80> {
+#if __SIZEOF_LONG_DOUBLE__ == 16
using StorageType = UInt128;
+#else
----------------
nickdesaulniers wrote:
Thinking ahead to android support, if android uses `long double == double` (https://developer.android.com/ndk/guides/abis#x86) https://godbolt.org/z/e35cEK4fM, then perhaps this aught to be an explicit check for `__SIZEOF_LONG_DOUBLE__ == 12` with an `#else` clause that errors explicitly so that we get a nice build failure if we tried to build llvm-libc using the android triple, and we could investigate proper `long double == double` support.
https://github.com/llvm/llvm-project/pull/115084
More information about the libc-commits
mailing list