[libc-commits] [libc] [libc][i386] FPBit support for 96b long double (PR #115084)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Wed Nov 6 09:12:44 PST 2024


================
@@ -469,7 +469,7 @@ struct BigInt {
                                                     !cpp::is_same_v<T, bool>>>
   LIBC_INLINE constexpr BigInt(T v) {
     constexpr size_t T_SIZE = sizeof(T) * CHAR_BIT;
-    const bool is_neg = Signed && (v < 0);
+    const bool is_neg = v < 0;
----------------
nickdesaulniers wrote:

I should add a test case to libc/test/src/__support/big_int_test.cpp that demonstrates _why_ this change is necessary.

https://github.com/llvm/llvm-project/pull/115084


More information about the libc-commits mailing list