[libc-commits] [PATCH] D150983: [libc] Fix test failing on the GPU due to undefined floating point type

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri May 19 12:00:28 PDT 2023


sivachandra added inline comments.


================
Comment at: libc/test/src/__support/FPUtil/fpbits_test.cpp:203
 
+  using UIntType = FPBits<long double>::UIntType;
   EXPECT_STREQ(FPBits<long double>::inf().str().c_str(), "(+Infinity)");
----------------
The best solution is likely to do this:

```
#ifdef LONG_DOUBLE_IS_DOUBLE
  return;
#else
  .. // The rest of this test.
#endif
```

Remove the `if constexpr` on line 200.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150983/new/

https://reviews.llvm.org/D150983



More information about the libc-commits mailing list