[libc-commits] [PATCH] D150983: [libc] Fix test failing on the GPU due to undefined floating point type

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri May 19 10:46:54 PDT 2023


jhuber6 created this revision.
jhuber6 added a reviewer: sivachandra.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

We got build failures due to the handling here, explicitly set the type.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150983

Files:
  libc/test/src/__support/FPUtil/fpbits_test.cpp


Index: libc/test/src/__support/FPUtil/fpbits_test.cpp
===================================================================
--- libc/test/src/__support/FPUtil/fpbits_test.cpp
+++ libc/test/src/__support/FPUtil/fpbits_test.cpp
@@ -200,6 +200,7 @@
   if constexpr (sizeof(long double) == sizeof(double))
     return; // The tests for the "double" type cover for this case.
 
+  using UIntType = FPBits<long double>::UIntType;
   EXPECT_STREQ(FPBits<long double>::inf().str().c_str(), "(+Infinity)");
   EXPECT_STREQ(FPBits<long double>::neg_inf().str().c_str(), "(-Infinity)");
   EXPECT_STREQ(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150983.523859.patch
Type: text/x-patch
Size: 591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230519/b2132dbb/attachment.bin>


More information about the libc-commits mailing list