[libc-commits] [PATCH] D146970: [libc] Install GPU headers to `llvm-libc/` subfolder

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Mar 27 11:46:54 PDT 2023


sivachandra added a comment.

In D146970#4225119 <https://reviews.llvm.org/D146970#4225119>, @jhuber6 wrote:

> These should be common between the gpu architecture, any target specific stuff should be hidden behind the `__NVPTX__` and `__AMDGPU__` macros. I'm in favor of `gpu-llvm` or `llvm-gpu` however. Since it makes it clear that these are GPU specific headers, separate from the system headers, and they were provided by and used in the LLVM toolchain.

I think `gpu-llvm` is almost ideal: It is for the GPU target and contains LLVM related/specific bits. Since target triples normally contains three components, I am tempted to say this should be `gpu-none-llvm`. The `none` kind of also indicates it is vendor agnostic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146970/new/

https://reviews.llvm.org/D146970



More information about the libc-commits mailing list