[libc-commits] [PATCH] D146970: [libc] Install GPU headers to `llvm-libc/` subfolder

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Mar 27 11:35:16 PDT 2023


jhuber6 added a comment.

In D146970#4225116 <https://reviews.llvm.org/D146970#4225116>, @sivachandra wrote:

> I prefer a name which is more in line with the triple formats listed here: https://clang.llvm.org/docs/CrossCompilation.html#target-triple
>
> 1. `gpu-none-llvm`
> 2. `gpu-amd-none-llvm` or `gpu-nvidia-none-llvm`

These should be common between the gpu architecture, any target specific stuff should be hidden behind the `__NVPTX__` and `__AMDGPU__` macros. I'm in favor of `gpu-llvm` or `llvm-gpu` however. Since it makes it clear that these are GPU specific headers, separate from the system headers, and they were provided by and used in the LLVM toolchain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146970/new/

https://reviews.llvm.org/D146970



More information about the libc-commits mailing list