[libc-commits] [PATCH] D146256: [libc] Enable integration tests targeting the GPU

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/test/integration/startup/gpu/args_test.cpp:1
+//===-- Loader test to check args to main ---------------------------------===//
+//
----------------
sivachandra wrote:
> jhuber6 wrote:
> > sivachandra wrote:
> > > jhuber6 wrote:
> > > > sivachandra wrote:
> > > > > I suppose you are not using the linux one because you don't have `envp` on the gpu? Or, is it future work? Also, unrelated to this change, what about global contructor/destructor on the GPUs?
> > > > I could copy the `env` over as well. Could do that in a follow-up patch
> > > If you copy the `envp` over, will the env vars checks pass?
> > Presumably, I'd just need to give it the same treatment that I gave for argv.
> You can do it as a follow up of course. At that point, can we merge the linux and gpu tests?
Yeah, we could do that. I'm wondering if I should add some more basic tests for the GPU right now. I'd like to be able to test the functionality of the entrypoints, but that's beyond the scope of these integration tests for now I believe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146256/new/

https://reviews.llvm.org/D146256