[libc-commits] [PATCH] D146256: [libc] Enable integration tests targeting the GPU

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

OK from the libc structuring point of view.



================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:415
   get_fq_target_name(${test_name} fq_target_name)
-  if(NOT (${LIBC_TARGET_OS} STREQUAL "linux"))
+  set(supported_targets gpu linux)
+  if(NOT (${LIBC_TARGET_OS} IN_LIST supported_targets))
----------------
Nit: `supported_platforms` may be, to avoid confusion with the "target cpu" or "build target".


================
Comment at: libc/test/integration/startup/gpu/args_test.cpp:1
+//===-- Loader test to check args to main ---------------------------------===//
+//
----------------
jhuber6 wrote:
> sivachandra wrote:
> > jhuber6 wrote:
> > > sivachandra wrote:
> > > > I suppose you are not using the linux one because you don't have `envp` on the gpu? Or, is it future work? Also, unrelated to this change, what about global contructor/destructor on the GPUs?
> > > I could copy the `env` over as well. Could do that in a follow-up patch
> > If you copy the `envp` over, will the env vars checks pass?
> Presumably, I'd just need to give it the same treatment that I gave for argv.
You can do it as a follow up of course. At that point, can we merge the linux and gpu tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146256/new/

https://reviews.llvm.org/D146256