[libc-commits] [PATCH] D146177: [libc] Add aliases to C memory functions for integration tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:451-452
       libc.src.unistd.environ
   )
-  list(APPEND memory_functions
+  list(APPEND fq_deps_list
       libc.src.string.bcmp
----------------
jhuber6 wrote:
> michaelrj wrote:
> > if these appends are both done unconditionally to the same list they can probably be combined.
> Soon I'm going to try to add the GPU integration test support, which will be different. I think we should make the former inherit all the dependencies from the `STARTUP` argument. What do you think @sivachandra?
Yes, that would be good. You can still combine them into a single `APPEND` operation and add some comment about why the memory functions are being added - a modified version of what was present on lines 477 to 480.


================
Comment at: libc/test/IntegrationTest/test.cpp:29
+
+extern "C" {
+int bcmp(const void *lhs, const void *rhs, size_t count) {
----------------
Nit: Empty lines between the definitions to improve readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146177/new/

https://reviews.llvm.org/D146177