[libc-commits] [PATCH] D146177: [libc] Add aliases to C memory functions for integration tests

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Mar 15 16:44:44 PDT 2023


jhuber6 added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:451-452
       libc.src.unistd.environ
   )
-  list(APPEND memory_functions
+  list(APPEND fq_deps_list
       libc.src.string.bcmp
----------------
michaelrj wrote:
> if these appends are both done unconditionally to the same list they can probably be combined.
Soon I'm going to try to add the GPU integration test support, which will be different. I think we should make the former inherit all the dependencies from the `STARTUP` argument. What do you think @sivachandra?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146177/new/

https://reviews.llvm.org/D146177



More information about the libc-commits mailing list