[libc-commits] [PATCH] D146001: [libc] enable printf using system FILE

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Mar 15 10:46:31 PDT 2023


michaelrj marked an inline comment as done.
michaelrj added inline comments.


================
Comment at: libc/test/src/stdio/CMakeLists.txt:163
+  COMPILE_OPTIONS
+    -DLIBC_COPT_PRINTF_USE_PUBLIC_FILE
+)
----------------
lntue wrote:
> @sivachandra : I would assume the current bazel build is kind of equivalent to overlay mode.  So do we need to add this flag to the bazel overlay?
the current bazel overlay doesn't have stdio yet, so this flag will be added after both this patch and the printf bazel patch (https://reviews.llvm.org/D146100) land.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146001/new/

https://reviews.llvm.org/D146001



More information about the libc-commits mailing list