[libc-commits] [PATCH] D146001: [libc] enable printf using system FILE

[Tue Ly via Phabricator via libc-commits]

lntue accepted this revision.
lntue added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/stdio/printf_core/file_writer.cpp:30
+#else // defined(LIBC_COPT_PRINTF_USE_PUBLIC_FILE)
+#include <stdio.h>
+
----------------
Can this `#include` be outside of the namespaces?


================
Comment at: libc/test/src/stdio/CMakeLists.txt:163
+  COMPILE_OPTIONS
+    -DLIBC_COPT_PRINTF_USE_PUBLIC_FILE
+)
----------------
@sivachandra : I would assume the current bazel build is kind of equivalent to overlay mode.  So do we need to add this flag to the bazel overlay?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146001/new/

https://reviews.llvm.org/D146001