[libc-commits] [PATCH] D151735: [libc] Implement basic `malloc` and `free` support on the GPU

Mon Jun 5 11:09:22 PDT 2023

jhuber6 added inline comments.

================
Comment at: libc/src/stdlib/CMakeLists.txt:247

 if(LLVM_LIBC_INCLUDE_SCUDO)
   set(SCUDO_DEPS "")
----------------
sivachandra wrote:
> Instead of spreading out the GPU conditionals, can we do this:
> 
> ```
> if(LIBC_TARGET_ARCHITECTURE_IS_GPU)
> ...
> elseif(LLVM_LIBC_INCLUDE_SCUDO)
> ...
> else()
> ...
> endif()
> ```
I can't move the GPU entrypoints here because they alias to something that is only defined after we include the `gpu/` subdirectory after the FULL_BUILD check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151735/new/

https://reviews.llvm.org/D151735