[libc-commits] [PATCH] D151735: [libc] Implement basic `malloc` and `free` support on the GPU

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/stdlib/CMakeLists.txt:300
+  # Only the GPU has an in-tree 'malloc' implementation.
+  if(LIBC_TARGET_ARCHITECTURE_IS_GPU)
+    add_libc_test(
----------------
jhuber6 wrote:
> sivachandra wrote:
> > In the interest of eliminating unnecessary conditionals, will it fail on linux if you remove this conditional?
> I think so, because the hermetic tests use `malloc` and this uses `__llvm_libc::malloc` which isn't defined anywhere AFAIK.
Ah, yes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151735/new/

https://reviews.llvm.org/D151735